-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Use gotestsum wrapper for go tests #11946
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11946 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 447 447
Lines 23729 23729
=======================================
Hits 21741 21741
Misses 1613 1613
Partials 375 375 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM since we already use this in contrib
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me
**Description:** Use [gotestyourself/gotestsum](https://github.com/gotestyourself/gotestsum?rgh-link-date=2024-02-09T12%3A20%3A03Z) for running tests. This is following contrib's lead - they implemented this in this [PR](open-telemetry/opentelemetry-collector-contrib#31163). Gotestsum is a lot more readable and user friendly than go test - the output format is nicer and the test output is more parseable. We could also use [rerun on failed](https://github.com/gotestyourself/gotestsum#re-running-failed-tests) or some of their other features! --------- Co-authored-by: Pablo Baeyens <[email protected]>
Description:
Use gotestyourself/gotestsum for running tests.
This is following contrib's lead - they implemented this in this PR.
Gotestsum is a lot more readable and user friendly than go test - the output format is nicer and the test output is more parseable. We could also use rerun on failed or some of their other features!